From: | Abhijit Menon-Sen <ams(at)toroid(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Naming of gss_accept_deleg |
Date: | 2023-05-22 15:03:34 |
Message-ID: | ZGuERm/B2UCuajzz@toroid.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At 2023-05-22 09:42:44 -0400, tgl(at)sss(dot)pgh(dot)pa(dot)us wrote:
>
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > I noticed that the value that enables this feature at libpq client side
> > is 'enable'. However, for other Boolean settings like sslsni,
> > keepalives, requiressl, sslcompression, the value that enables feature
> > is '1' -- we use strings only for "enum" type of settings.
>
> > Also, it looks like connectOptions2() doesn't validate the string value.
>
> Hmm, it certainly seems like this ought to accept exactly the
> same inputs as other libpq boolean settings. I can take a look
> unless somebody else is already on it.
Here's the diff, but the 0/1 values of settings like sslsni and
sslcompression don't seem to be validated anywhere, unlike the string
options in connectOptions2, so I didn't do anything for gssdelegation.
(I've never run the Kerberos tests before, but I changed one
"gssdelegation=disable" to "gssdelegation=1" and got a test failure, so
they're probably working as expected.)
-- Abhijit
Attachment | Content-Type | Size |
---|---|---|
deleg-bool.diff | text/x-diff | 14.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2023-05-22 15:08:16 | Re: Naming of gss_accept_deleg |
Previous Message | Tristan Partin | 2023-05-22 15:02:02 | Make pgbench exit on SIGINT more reliably |