From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands |
Date: | 2023-05-16 06:28:17 |
Message-ID: | ZGMigV+oBj4LjsFB@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, May 15, 2023 at 12:36:51PM -0700, Nathan Bossart wrote:
> There's still some time before we'll be able to commit any of these, but
> here is an attempt at addressing all the feedback thus far.
- The parenthesized syntax was added in
- <productname>PostgreSQL</productname> 9.0; the unparenthesized
- syntax is deprecated.
[...]
+ | CLUSTER '(' utility_option_list ')'
+ {
+ ClusterStmt *n = makeNode(ClusterStmt);
+
+ n->relation = NULL;
+ n->indexname = NULL;
+ n->params = $3;
+ $$ = (Node *) n;
+ }
Hmm. This is older than the oldest version we have to support for
pg_upgrade and co. Would it be worth switching clusterdb to use the
parenthesized grammar, adding on the way a test for this new grammar
flavor without a table in the TAP tests (too costly for the main
regression test suite)?
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2023-05-16 06:36:08 | Re: running logical replication as the subscription owner |
Previous Message | Drouvot, Bertrand | 2023-05-16 06:18:04 | Re: walsender performance regression due to logical decoding on standby changes |