Re: Make pgbench exit on SIGINT more reliably

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tristan Partin <tristan(at)neon(dot)tech>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Make pgbench exit on SIGINT more reliably
Date: 2023-05-24 00:31:34
Message-ID: ZG1a5lsSXXiYVJQ6@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 22, 2023 at 10:02:02AM -0500, Tristan Partin wrote:
> The way that pgbench handled SIGINT changed in
> 1d468b9ad81b9139b4a0b16b416c3597925af4b0. Unfortunately this had a
> couple of unintended consequences, at least from what I can tell[1].
>
> - CTRL-C no longer stops the program unless the right point in pgbench
> execution is hit
> - pgbench no longer exits with a non-zero exit code
>
> An easy reproduction of these problems is to run with a large scale
> factor like: pgbench -i -s 500000. Then try to CTRL-C the program.

This comes from the code path where the data is generated client-side,
and where the current CancelRequested may not be that responsive,
isn't it?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2023-05-24 00:34:27 Re: Large files for relations
Previous Message Michael Paquier 2023-05-24 00:17:16 Re: RFI: Extending the TOAST Pointer