| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, gkokolatos(at)pm(dot)me, shiy(dot)fnst(at)fujitsu(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, Rachel Heaton <rachelmheaton(at)gmail(dot)com> |
| Subject: | Re: Add LZ4 compression in pg_dump |
| Date: | 2023-04-12 22:23:48 |
| Message-ID: | ZDcvdPVVi22mXPfR@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 11, 2023 at 08:19:59PM -0500, Justin Pryzby wrote:
> On Wed, Apr 12, 2023 at 10:07:08AM +0900, Michael Paquier wrote:
>> Yes, this comment gives no value as it stands. I would be tempted to
>> follow the suggestion to group the whole code block in a single ifdef,
>> including the check, and remove this comment. Like the attached
>> perhaps?
>
> +1
Let me try this one again, as the previous patch would cause a warning
under --without:-zlib as user_compression_defined would be unused. We
could do something like the attached instead. It means doing twice
parse_compress_specification() for the non-zlib path, still we are
already doing so for the zlib path.
If there are other ideas, feel free.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| pgdump-comment-2.patch | text/x-diff | 1006 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-04-12 22:38:55 | Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests |
| Previous Message | David Rowley | 2023-04-12 22:09:39 | Re: Fix incorrect start up costs for WindowAgg paths (bug #17862) |