| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Fujii(dot)Yuki(at)df(dot)MitsubishiElectric(dot)co(dot)jp" <Fujii(dot)Yuki(at)df(dot)mitsubishielectric(dot)co(dot)jp>, Andres Freund <andres(at)anarazel(dot)de>, Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Ilya Gladyshev <i(dot)gladyshev(at)postgrespro(dot)ru> |
| Subject: | Re: Partial aggregates pushdown |
| Date: | 2023-04-08 02:53:53 |
| Message-ID: | ZDDXQbPxdNU63i0S@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 7, 2023 at 10:44:09PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > On Fri, Apr 7, 2023 at 09:55:00PM -0400, Tom Lane wrote:
> >> Uh, what? Why would we not be able to tell from the remote server's
> >> version number whether it has this ability?
>
> > The issue is not a mismatch of postgres_fdw versions but the extension
> > versions and whether the partial aggregate functions exist on the remote
> > side, e.g., something like a PostGIS upgrade.
>
> postgres_fdw has no business pushing down calls to non-builtin functions
> unless the user has explicitly authorized that via the existing
> whitelisting mechanism. I think you're reinventing the wheel,
> and not very well.
The patch has you assign an option at CREATE AGGREGATE time if it can do
push down, and postgres_fdw checks that. What whitelisting mechanism
are you talking about? async_capable?
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Embrace your flaws. They make you human, rather than perfect,
which you will never be.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-04-08 03:03:17 | Re: daitch_mokotoff module |
| Previous Message | Andrew Dunstan | 2023-04-08 02:50:32 | Re: daitch_mokotoff module |