Re: Fix typos and inconsistencies for v16

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Fix typos and inconsistencies for v16
Date: 2023-04-18 18:47:21
Message-ID: ZD7luYOGJs8DtDcJ@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 18, 2023 at 02:06:43PM +1200, David Rowley wrote:
> On Tue, 18 Apr 2023 at 10:10, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> > > - * USER SET values are appliciable only for PGC_USERSET parameters. We
> > > + * USER SET values are applicable only for PGC_USERSET parameters. We
> > > * use InvalidOid as role in order to evade possible privileges of the
> >
> > and s/evade/avoid/
>
> I didn't touch this. You'll need to provide more justification for why
> you think it's more correct than what's there.

I'd noticed that it's a substitution/mistake that's been made in the
past. I dug up:

9436041ed848debb3d64fb5fbff6cdb35bc46d04
8e12f4a250d250a89153da2eb9b91c31bb80c483
cd9479af2af25d7fa9bfd24dd4dcf976b360f077
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
911e70207703799605f5a0e8aad9f06cff067c63

> It might not be worth too much discussion, however.

+many. I may resend the patch at some later date.

> > Attached some others that I found.
>
> Pushed the rest. Thanks

Thanks!

--
Justin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Lakhin 2023-04-18 19:00:00 Re: Fix typos and inconsistencies for v16
Previous Message Tom Lane 2023-04-18 17:34:12 Re: pgsql: psql: add an optional execution-count limit to \watch.