Re: Fix typos and inconsistencies for v16

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Fix typos and inconsistencies for v16
Date: 2023-04-17 22:10:29
Message-ID: ZD3D1QxoccnN8A1V@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 17, 2023 at 09:00:00PM +0300, Alexander Lakhin wrote:
> Hello hackers,
>
> Please consider fixing the following unique words/identifiers introduced in v16:

Well done.

Note that your patches are overlapping:

3 --- a/src/backend/utils/misc/guc.c
2 --- a/src/test/perl/PostgreSQL/Test/BackgroundPsql.pm
2 --- a/src/test/ldap/LdapServer.pm
2 --- a/src/interfaces/libpq/t/004_load_balance_dns.pl
2 --- a/src/backend/utils/adt/acl.c

It'd make sense if the changes to each file were isolated to a single
patch (especially 004_load and acl.c).

> - * USER SET values are appliciable only for PGC_USERSET parameters. We
> + * USER SET values are applicable only for PGC_USERSET parameters. We
> * use InvalidOid as role in order to evade possible privileges of the

and s/evade/avoid/

> +++ b/src/bin/pg_dump/pg_dumpall.c

You missed "boostrap" :)

I independently found 11 of the same typos you did:

> 1. addresess -> addresses
> 3. appeneded -> appended
> 4. appliciable -> applicable
> 8. containsthe ->  contains the
> 15. execpt -> except
> 19. happend -> happened
> 27. optionn -> option
> 30. permissons -> permissions
> 37. remaing -> remaining
> 42. sentinal -> sentinel
> 47. varilables -> variables

But hadn't yet convinced myself to start the process of defending each
one of the fixes. Attached some others that I found.

--
Justin

Attachment Content-Type Size
v5.txt text/plain 14.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amin 2023-04-17 22:34:18 Re: Scans are offloaded to SeqScan instead of CustomScan when there are multiple relations in the same query
Previous Message Tom Lane 2023-04-17 22:09:44 Re: v16dev: TRAP: failed Assert("size > SizeOfXLogRecord"), File: "xlog.c", Line: 1055, PID: 13564