Re: [BUG] pg_stat_statements and extended query protocol

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUG] pg_stat_statements and extended query protocol
Date: 2023-04-04 12:15:14
Message-ID: ZCwU0qrZjzAsT0ai@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 04, 2023 at 03:29:07AM +0000, Imseih (AWS), Sami wrote:
>> We clearly do need to fix the
>> reported rowcount for cases where ExecutorRun is invoked more than
>> once per ExecutorEnd call; but I think that's sufficient.
>
> Sure, the original proposed fix, but with tracking the es_total_processed
> only in Estate should be enough for now.

I was looking back at this thread, and the suggestion to use one field
in EState sounds fine to me. Sami, would you like to send a new
version of the patch (simplified version based on v1)?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2023-04-04 12:22:00 Re: fairywren exiting in ecpg
Previous Message Michael Paquier 2023-04-04 12:04:34 Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry