| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, melanieplageman(at)gmail(dot)com, boekewurm+postgres(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Add pg_walinspect function with block info columns |
| Date: | 2023-03-28 03:37:03 |
| Message-ID: | ZCJg310jyes294im@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 27, 2023 at 06:07:09PM -0700, Peter Geoghegan wrote:
> I see a bug on HEAD, following yesterday's commit 0276ae42dd.
>
> GetWALRecordInfo() will now output the value of the fpi_len variable
> before it has actually been set by our call to XXXX. So it'll always
> be 0.
Indeed, good catch. It looks like I was not careful enough with the
block controlled by XLogRecHasAnyBlockRefs().
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2023-03-28 03:50:06 | Re: PGdoc: add missing ID attribute to create_subscription.sgml |
| Previous Message | Kyotaro Horiguchi | 2023-03-28 03:36:15 | Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry |