| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix fseek() detection of unseekable files on WIN32 |
| Date: | 2023-03-19 11:20:27 |
| Message-ID: | ZBbv+wfxsAXI4mqc@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 16, 2023 at 10:08:44AM +0100, Juan José Santamaría Flecha wrote:
> IDK, this is just looking for the good case, anything else we'll fail with
> ESPIPE or EINVAL anyway. If we want to get the proper file type we can call
> fstat(), which has the full logic.
I am not sure, TBH. As presented, the two GetFileType() calls in
_pgftello64() and _pgfseeko64() ignore the case where it returns
FILE_TYPE_UNKNOWN and GetLastError() has something else than
NO_ERROR. The code would return EINVAL for all the errors happening.
Perhaps that's fine, though I am wondering if we should report
something more exact, based on _dosmaperr(GetLastError())?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeevan Ladhe | 2023-03-19 11:29:17 | server log inflates due to pg_logical_slot_peek_changes/pg_logical_slot_get_changes calls |
| Previous Message | Michail Nikolaev | 2023-03-19 09:43:43 | Replace known_assigned_xids_lck by memory barrier |