| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | boekewurm+postgres(at)gmail(dot)com, bharath(dot)rupireddyforpostgres(at)gmail(dot)com, melanieplageman(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org, pg(at)bowt(dot)ie |
| Subject: | Re: Add pg_walinspect function with block info columns |
| Date: | 2023-03-07 07:18:21 |
| Message-ID: | ZAblPeGOe4bxY0HE@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 07, 2023 at 03:49:02PM +0900, Kyotaro Horiguchi wrote:
> Ah. Yes, that expansion sounds sensible.
Okay, so, based on this idea, I have hacked on this stuff and finish
with the attached that shows block data if it exists, as well as FPI
stuff if any. bimg_info is showed as a text[] for its flags.
I guess that I'd better add a test that shows correctly a record with
some block data attached to it, on top of the existing one for FPIs..
Any suggestions? Perhaps just a heap/heap2 record?
Thoughts?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Rework-pg_walinspect-to-retrieve-more-block-informat.patch | text/x-diff | 18.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2023-03-07 07:33:11 | Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes? |
| Previous Message | Bharath Rupireddy | 2023-03-07 07:09:13 | Re: Improve WALRead() to suck data directly from WAL buffers when possible |