From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | michael(at)paquier(dot)xyz |
Cc: | boekewurm+postgres(at)gmail(dot)com, bharath(dot)rupireddyforpostgres(at)gmail(dot)com, melanieplageman(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org, pg(at)bowt(dot)ie |
Subject: | Re: Add pg_walinspect function with block info columns |
Date: | 2023-03-07 06:49:02 |
Message-ID: | 20230307.154902.1060895277048303254.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At Tue, 7 Mar 2023 14:44:49 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in
> On Tue, Mar 07, 2023 at 11:17:45AM +0900, Kyotaro Horiguchi wrote:
> > Thus I'm inclined to agree with Michael's suggestion of creating a new
> > normalized set-returning function that returns information of
> > "blocks".
>
> Just to be clear here, I am not suggesting to add a new function for
> only the block information, just a rename of the existing
> pg_get_wal_fpi_info() to something like pg_get_wal_block_info() that
> includes both the FPI (if any or NULL if none) and the block data (if
> any or NULL is none) so as all of them are governed by the same lookup
> at pg_wal/. The fpi information (aka compression type) is displayed
> if there is a FPI in the block.
Ah. Yes, that expansion sounds sensible.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Kartyshov Ivan | 2023-03-07 06:55:48 | Re: [HACKERS] make async slave to wait for lsn to be replayed |
Previous Message | Julien Rouhaud | 2023-03-07 06:47:05 | Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes? |