| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Israel Barth Rubio <barthisrael(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add -k/--link option to pg_combinebackup |
| Date: | 2025-03-17 18:17:12 |
| Message-ID: | Z9hnKP8mtoiBF5EG@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 17, 2025 at 02:10:14PM -0400, Robert Haas wrote:
> Now, to see if the buildfarm explodes...
I think koel might complain. pgindent on my machine yields the following:
diff --git a/src/bin/pg_combinebackup/copy_file.c b/src/bin/pg_combinebackup/copy_file.c
index 97ecda5a66d..b0c94f6ee31 100644
--- a/src/bin/pg_combinebackup/copy_file.c
+++ b/src/bin/pg_combinebackup/copy_file.c
@@ -72,9 +72,10 @@ copy_file(const char *src, const char *dst,
}
#ifdef WIN32
+
/*
- * We have no specific switch to enable CopyFile on Windows, because
- * it's supported (as far as we know) on all Windows machines. So,
+ * We have no specific switch to enable CopyFile on Windows, because it's
+ * supported (as far as we know) on all Windows machines. So,
* automatically enable it unless some other strategy was selected.
*/
if (copy_method == COPY_METHOD_COPY)
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-03-17 18:19:37 | Re: dead code in pg_upgrade |
| Previous Message | Robert Haas | 2025-03-17 18:10:14 | Re: Add -k/--link option to pg_combinebackup |