Re: Dubious server log messages after pg_upgrade

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, michael(at)paquier(dot)xyz
Subject: Re: Dubious server log messages after pg_upgrade
Date: 2025-03-13 01:39:41
Message-ID: Z9I3XSM-uJbFSAF-@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 12, 2025 at 08:41:29PM -0400, Tom Lane wrote:
> The "corrupted statistics file" whine is most likely
> caused by pg_upgrade copying the old system's pgstat.stat file
> into the new installation --- is that a good idea?

I don't believe pg_upgrade copies that file to the new cluster. At least,
that would be news to me.

> I have
> no idea what's causing the redo LSN complaint, but it seems
> like that might deserve closer investigation.

pgstat_read_statsfile() emits a warning before it jumps to the section that
emits the LOG. The LSN complaint seems to just be providing some context
around what exactly is corrupted in pgstat.stat. Commit b860848 seems
rather suspect. I've added Michael here...

--
nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2025-03-13 02:06:41 Re: Separate GUC for replication origins
Previous Message Masahiko Sawada 2025-03-13 01:05:02 Re: pg_rewind with --write-recovery-conf option doesn't write dbname to primary_conninfo value.