Re: Add contrib/pg_logicalsnapinspect

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Peter Smith <smithpb2250(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add contrib/pg_logicalsnapinspect
Date: 2025-03-06 08:34:23
Message-ID: Z8leDyrPekPH4D2k@ip-10-97-1-34.eu-west-3.compute.internal
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Wed, Mar 05, 2025 at 11:28:23PM -0800, Masahiko Sawada wrote:
> On Wed, Mar 5, 2025 at 3:10 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> > Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> writes:
> > > yeah makes sense. Done in the attached, and bonus point I realized that the
> > > test could be simplified (so, removing useless steps in passing).
> >
> > Just a side note: tayra showed two instances of this failure today
> > [1][2]. That's not using valgrind.

Thanks for the report!

> I wonder if we changed something
> > else recently that would make this more probable?
> >
>
> I've observed the third failure.

I also did a "slow" test with the code tree at 7cdfeee320e and I can observe
the same "issue".

> I'm not sure
> what caused tayra to be slower overall recently.

yeah, tayra being slower is what make the test failure more probable. I'm also
not sure as to why.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2025-03-06 08:48:40 Re: Statistics Import and Export
Previous Message Alexander Korotkov 2025-03-06 08:23:29 Re: Replace IN VALUES with ANY in WHERE clauses during optimization