| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_combinebackup PITR comparison test fix |
| Date: | 2024-12-15 01:34:07 |
| Message-ID: | Z14yD2AJ_xuLyAsj@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Dec 14, 2024 at 09:57:11PM +0000, Dagfinn Ilmari Mannsåker wrote:
> While I was going through the TAP tests to fix the formatting of command
> argument lists to be less confusing, I noticed that pg_combinebackup's
> 002_compare_backups.pl test accidentally ran pg_dumpall twice against
> the same database, thus rendering the tests useless.
>
> Fixing that revealed that there is a difference in the dumps: the
> tablespaces have different paths. pg_dumpall doesn't have an option to
> map tablespace paths, so instead I used File::Compare::compare_text()
> with a custom comparison function to erase the difference.
Indeed, good catch. I'll take care of it.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-12-15 01:38:44 | Re: Conflict detection for update_deleted in logical replication |
| Previous Message | Tom Lane | 2024-12-14 22:08:19 | Re: Converting contrib SQL functions to new style |