Re: Misprints in code

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Erik Wienhold <ewie(at)ewie(dot)name>
Cc: el481(at)yandex(dot)ru, pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: Misprints in code
Date: 2024-11-25 00:06:21
Message-ID: Z0O_fd8tXxw12klx@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Thu, Nov 21, 2024 at 04:31:07PM +0100, Erik Wienhold wrote:
> Good catch! That's a leftover from Python 2 and missed in commit
> 4228cabb72b after Python 2 was dropped in 15.0. Patch attached.
>
> While looking at, we can also simplify a couple of plpython3u test
> functions that still try res.next() before res.__next__(). Attached as
> a separate patch.

Sounds about right to me, the example greet() fails with plpython3.
For reference, this has been implemented in upstream here:
https://peps.python.org/pep-3114/

The existing tests of plpython mentioned this link, and I've bumped
over it again while looking for references on the matter.

Will fix. Thanks for the report!
--
Michael

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message Peter Smith 2024-11-25 00:55:12 Re: Logical replication - initial data synchronization
Previous Message PG Doc comments form 2024-11-24 21:30:25 Clarification Needed on VARIADIC Keyword Explanation