Re: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t"

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>
Subject: Re: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t"
Date: 2022-09-26 07:50:36
Message-ID: YzFZzIMcDx7nQk24@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 26, 2022 at 06:57:28AM +0000, kuroda(dot)hayato(at)fujitsu(dot)com wrote:
> While reviewing [1], I and Amit noticed that a flag ParallelMessagePending is defined
> as "volatile bool", but other flags set by signal handlers are defined as "volatile sig_atomic_t".
>
> How do you think?

You are right. bool is not usually a problem in a signal handler, but
sig_atomic_t is the type we ought to use. I'll go adjust that.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-09-26 08:00:56 Re: DROP OWNED BY is broken on master branch.
Previous Message Rushabh Lathia 2022-09-26 07:43:53 DROP OWNED BY is broken on master branch.