Re: Move backup-related code to xlogbackup.c/.h

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Move backup-related code to xlogbackup.c/.h
Date: 2022-10-05 07:50:25
Message-ID: Yz03Qff/
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Oct 04, 2022 at 03:54:20PM -0700, Nathan Bossart wrote:
> I would suggest moving this to a separate prerequisite patch that can be
> reviewed independently from the patches that simply move code to a
> different file.

And FWIW, the SQL interfaces for pg_backup_start() and
pg_backup_stop() could stay in xlogfuncs.c. This has the advantage to
centralize in the same file all the SQL-function-specific checks.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-10-05 07:57:00 Re: Suppressing useless wakeups in walreceiver
Previous Message Michael Paquier 2022-10-05 07:46:25 Re: Non-replayable WAL records through overflows and >MaxAllocSize lengths