Re: pg_upgrade test failure

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade test failure
Date: 2022-09-20 01:08:41
Message-ID: YykSmXbGi08agCRq@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, Sep 19, 2022 at 02:32:17PM -0700, Andres Freund wrote:
> I don't know if actually related to the commit below, but there've been a
> lot of runs of the pg_upgrade tests in the meson branch, and this is the first
> failure of this kind. Unfortunately the error seems to be transient -
> rerunning the tests succeeded.

This smells to me like a race condition in pg_upgrade (or even pg_ctl
for SERVER_LOG_FILE) where the code still has handles on some of the
files in the log/ subdirectory, causing its removal to not be able to
finish happen. If this proves to be rather easy to reproduce, giving
a list of the files still present in this path would give a hint easy
to follow. Does this reproduce with a good frequency?
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-09-20 01:13:17 Re: pg_upgrade test failure
Previous Message Peter Geoghegan 2022-09-19 23:47:06 pgsql: Harmonize heapam and tableam parameter names.

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2022-09-20 01:11:56 Re: Reducing the chunk header sizes on all memory context types
Previous Message Michael Paquier 2022-09-20 00:53:58 Re: Support tls-exporter as channel binding for TLSv1.3