From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, okano(dot)naoki(at)jp(dot)fujitsu(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
Subject: | Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work. |
Date: | 2022-09-16 12:51:40 |
Message-ID: | YyRxXJ+FXOWTBBrb@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Sun, Mar 27, 2022 at 12:07:57AM +1300, Thomas Munro wrote:
> Some question I have: is FILE_MAP_LARGE PAGES a macro? We claim to
> support all those ancient zombie OSes like Windows 7, or maybe it's
> even XP for 11, and this has to be back-patched to 11, so we might
> need to make it conditional. But conditional on what? For example,
> does something like the attached work (untested)? What happens if a <
> 1703 kernel sees this flag, does it reject it or ignore it?
I have been looking at this thread, and found an answer in an example
of application creating a map object with large pages in [1]:
"This flag is ignored on OS versions before Windows 10, version 1703."
So based on that I think that we could just apply and backpatch what
you have here. This issue is much easier to reason about on HEAD
where we just care about Win >= 10, and we've be rather careful with
changes like that when it came to Windows. Any objections about doing
a backpatch? I'd like to do so after an extra lookup, if there are no
objections. Or would folks prefer a HEAD-only fix for now?
[1]: https://docs.microsoft.com/en-us/windows/win32/memory/creating-a-file-mapping-using-large-pages?source=recommendations
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-09-16 14:29:38 | Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work. |
Previous Message | PG Bug reporting form | 2022-09-16 10:00:24 | BUG #17616: Silently skipping to update data to the database with owner privileges using flyway scripts |
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2022-09-16 12:53:36 | Re: Query Jumbling for CALL and SET utility statements |
Previous Message | Japin Li | 2022-09-16 12:48:37 | Re: Error for WITH options on partitioned tables |