Re: freeing LDAPMessage in CheckLDAPAuth

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: freeing LDAPMessage in CheckLDAPAuth
Date: 2022-09-05 05:37:23
Message-ID: YxWLE7zWz7PyFiep@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Sep 04, 2022 at 06:52:37AM -0700, Zhihong Yu wrote:
> Please take a look at patch v3.

Fine as far as it goes. I would have put the initialization of
search_message closer to ldap_search_s() for consistency with libpq.
That's what we do with ldap_search_st().
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2022-09-05 06:17:35 Re: SQL/JSON features for v15
Previous Message Kyotaro Horiguchi 2022-09-05 05:34:36 Re: pg15b3: recovery fails with wal prefetch enabled