| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix obsoleted comments for function prototypes |
| Date: | 2022-08-02 10:25:49 |
| Message-ID: | Yuj7rfJlvTAnoHzW@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 02, 2022 at 05:06:44PM +0800, Richard Guo wrote:
> While doing the search in [1], I spotted several places where the
> comments for the function prototypes are obsoleted. For instance,
> btree_desc() and btree_identify() are now located in nbtdesc.c but the
> comment in nbtxlog.h is still claiming they are in nbtxlog.c.
>
> Fix these places with the attached. With high possibility there are
> other places with this kind of obsoleted comments, but I don't know how
> to find them all :-(.
These declarations are linked to comments with their file paths, so
making that automated looks rather complicated to me. I have looked
at the surroundings without noticing anything obvious, so what you
have caught here sounds fine to me, good catches :)
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-08-02 10:28:41 | Re: [PATCH] Fix pg_upgrade test from v10 |
| Previous Message | John Naylor | 2022-08-02 10:22:52 | support for SSE2 intrinsics |