| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Improve TAP tests of pg_upgrade for cross-version tests |
| Date: | 2022-07-30 07:29:16 |
| Message-ID: | YuTdzCf0pvuqVlYY@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 29, 2022 at 04:15:26PM -0500, Justin Pryzby wrote:
> This was using the old psql rather than the new one.
> Before v10, psql didn't have \if.
# Note that upgrade_adapt.sql from the new version is used, to
# cope with an upgrade to this version.
- $oldnode->command_ok(
+ $newnode->command_ok(
[
- 'psql', '-X',
+ "$newbindir/psql", '-X',
Yeah, you are right here that this psql command should use the one
from the new cluster and connect to the old cluster. There is no
point in adding $newbindir though as Cluster::_get_env would enforce
PATH to find the correct binary. I'll look at that in details later.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2022-07-30 08:09:36 | Re: Allow file inclusion in pg_hba and pg_ident files |
| Previous Message | Michael Paquier | 2022-07-30 07:21:07 | Re: Support for grabbing multiple consecutive values with nextval() |