Re: Inconvenience of pg_read_binary_file()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Inconvenience of pg_read_binary_file()
Date: 2022-07-30 05:51:38
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Jul 29, 2022 at 11:35:36PM -0400, Tom Lane wrote:
> Hm. I considered reading PG_VERSION instead, or
> PG_VERSION would be a very boring test case, but it should certainly
> be present in $PGDATA.

PG_VERSION would be simpler. Looking at would require
a lookup at external_pid_file, and as it is not set by default you
would need to add some extra logic in the tests where
external_pid_file = NULL <=> PGDATA/

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message mahendrakar s 2022-07-30 06:53:47 Re: A proposal for shared memory based backup infrastructure
Previous Message Noah Misch 2022-07-30 05:44:01 Re: pg15b2: large objects lost on upgrade