Re: Reducing logs produced by TAP tests running pg_regress on crash

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Reducing logs produced by TAP tests running pg_regress on crash
Date: 2022-07-23 03:07:25
Message-ID: Yttl7QnBOwln5k1W@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 22, 2022 at 01:18:34PM +1200, Thomas Munro wrote:
> I wonder if we should move the noise suppression check closer to
> pg_regress, so that it works also for the "main" pg_regress run, not
> only the one in this new TAP test. As discussed in this thread,
> inconclusively:

Yes, perhaps. We could reduce the amount of junk generated in
regression.diffs in a more centralized way with this approach, and
I agree that this should use restart_after_crash=off as well as
something to prevent more tests to run if we are not able to connect,
as you mentioned there. At least this would reduce the spam down to
tests running in parallel to the session that crashed.

> https://www.postgresql.org/message-id/flat/CA%2BhUKGL7hxqbadkto7e1FCOLQhuHg%3DwVn_PDZd6fDMbQrrZisA%40mail.gmail.com

Ah, I forgot about this recent thread. Let's just move the discussion
there. Thanks!

I am planning to remove this open item from the list and mark it as
"won't fix", as this is a much older issue.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhihong Yu 2022-07-23 03:20:04 potential memory leak in pg_regcomp()
Previous Message Michael Paquier 2022-07-23 02:58:30 Re: pg_tablespace_location() failure with allow_in_place_tablespaces