From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Reducing logs produced by TAP tests running pg_regress on crash |
Date: | 2022-07-22 01:09:51 |
Message-ID: | Ytn435jpCCGunCUh@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jun 23, 2022 at 02:30:13PM +0900, Michael Paquier wrote:
> One idea I got to limit the useless output generated is to check the
> status of the cluster after running the regression test suite as
> restart_on_crash is disabled by default in Cluster.pm, and avoid any
> follow-up logic in these tests if the cluster is not running anymore,
> as of the attached.
So, this is still an open item..
Thomas, any objections about this one? Checking for the status of the
node after completing pg_regress still sounds like a good idea to me,
because as restart_after_crash is disabled we would generate a ton of
logs coming from regression.diffs for nothing. On top of that the
parallel connections make harder finding which query failed, and the
logs of the backend provide enough context already on a hard crash.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2022-07-22 01:18:34 | Re: Reducing logs produced by TAP tests running pg_regress on crash |
Previous Message | Kyotaro Horiguchi | 2022-07-22 01:02:57 | Re: standby recovery fails (tablespace related) (tentative patch and discussion) |