| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Dave Page <dpage(at)pgadmin(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Windows now has fdatasync() |
| Date: | 2022-07-19 04:54:43 |
| Message-ID: | YtY5ExZhymERILrG@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 18, 2022 at 03:26:36PM +1200, Thomas Munro wrote:
> My plan now is to commit this patch so that problem #1 is solved, prod
> conchuela's owner to upgrade to solve #2, and wait until Tom shuts
> down prairiedog to solve #3. Then we could consider removing the
> HAVE_FDATASYNC probe and associated #ifdefs when convenient. For that
> reason, I'm not too bothered about the slight weirdness of defining
> HAVE_FDATASYNC on Windows even though that doesn't come from
> configure; it'd hopefully be short-lived. Better ideas welcome,
> though. Does that make sense?
Do you still need HAVE_DECL_FDATASYNC?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2022-07-19 05:31:04 | Re: System catalog documentation chapter |
| Previous Message | Amit Kapila | 2022-07-19 04:47:15 | Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns |