Re: defGetBoolean - Fix comment

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: defGetBoolean - Fix comment
Date: 2022-07-07 00:54:24
Message-ID: YsYuwFloB3NVEi4q@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 07, 2022 at 09:53:01AM +1000, Peter Smith wrote:
> Really this code is for the case when there *was* a parameter given
> (e.g. "copy_data" in my example above) but when there is no parameter
> *value* given.
>
> Suggested comment fix:
> BEFORE
> If no parameter given, assume "true" is meant.
> AFTER
> If no parameter value given, assume "true" is meant.

Still, I think that your adjustment is right, as the check is, indeed,
on the DefElem's value*. Or you could just say "If no value given".
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-07-07 01:04:18 Re: pg_parameter_aclcheck() and trusted extensions
Previous Message Andres Freund 2022-07-07 00:46:46 Re: BUG #17540: Prepared statement: PG switches to a generic query plan which is consistently much slower