| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix proposal for comparaison bugs in PostgreSQL::Version |
| Date: | 2022-06-29 01:20:10 |
| Message-ID: | YruoymSg9OQJb7QP@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 28, 2022 at 06:17:40PM -0400, Andrew Dunstan wrote:
> Nice catch, but this looks like massive overkill. I think we can very
> simply fix the test in just a few lines of code, instead of a 190 line
> fix and a 130 line TAP test.
>
> It was never intended to be able to compare markers like rc1 vs rc2, and
> I don't see any need for it. If you can show me a sane use case I'll
> have another look, but right now it seems quite unnecessary.
>
> Here's my proposed fix.
Do you think that we should add some tests for that? One place that
comes into mind is test_misc/, and this would be cheap as this does
not require setting up a node or such.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-06-29 02:52:02 | Re: better error description on logical replication |
| Previous Message | Michael Paquier | 2022-06-29 01:17:15 | Re: Export log_line_prefix(); useful for emit_log_hook. |