| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Przemysław Sztoch <przemyslaw(at)sztoch(dot)pl> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: [PATCH] Completed unaccent dictionary with many missing characters |
| Date: | 2022-06-28 05:14:53 |
| Message-ID: | YrqOTZBFoRNOOuz5@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 23, 2022 at 02:10:42PM +0200, Przemysław Sztoch wrote:
> The only division that is probably possible is the one attached.
Well, the addition of cyrillic does not make necessary the removal of
SOUND RECORDING COPYRIGHT or the DEGREEs, that implies the use of a
dictionnary when manipulating the set of codepoints, but that's me
being too picky. Just to say that I am fine with what you are
proposing here.
By the way, could you add a couple of regressions tests for each
patch with a sample of the characters added? U+210C is a particularly
sensitive case, as we should really make sure that it maps to what we
want even if Latin-ASCII.xml tells a different story. This requires
the addition of a couple of queries in unaccent.sql with the expected
output updated in unaccent.out.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2022-06-28 06:17:53 | Re: Handle infinite recursion in logical replication setup |
| Previous Message | Andres Freund | 2022-06-28 05:02:11 | Re: [PoC] Improve dead tuple storage for lazy vacuum |