| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, robertmhaas(at)gmail(dot)com, christoph(dot)berg(at)credativ(dot)de, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still commits after client-side error |
| Date: | 2022-06-15 06:09:53 |
| Message-ID: | Yql3sc3cvYvLlEHu@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Jun 14, 2022 at 10:31:21AM +0900, Michael Paquier wrote:
> Okay, let's do so then on HEAD. I'll wait a bit more, in case others
> have an opinion to offer on the matter.
Well, done. One thing that I find a bit surprising in all that is the
lack of consistency in the handling of the return code of psql when
the last switch fails when not using ON_ERROR_STOP. For example, psql
fails if the last switch is a slash command from -c, but succeeds if
the last switch is a slash command in a file from -f that exists.
This comes down to the way failures are passed down from MainLoop() so
I am not sure if this is worth worrying about and nobody has
complained about that AFAIK, but I have added some extra tests to at
least document everything I could think about to track changes, in
case somebody plays with this code in the future.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2022-06-15 09:13:56 | psql --on-error-stop (Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still) commits after client-side error |
| Previous Message | Justin Pryzby | 2022-06-14 23:09:49 | Re: pg_upgrade (12->14) fails on aggregate |