Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test
Date: 2022-06-15 00:48:14
Message-ID: YqksTlm+89FwXWzz@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Jun 14, 2022 at 08:11:59PM -0400, Tom Lane wrote:
> Sorry, I wasn't very clear: I'd tested pg_upgrade with a manual
> invocation, like "./pg_upgrade -d ...". That used to be OK and
> now it leaves junk around. I think it's worth keeping the
> .gitignore entries (and I guess the "make clean" rule step too)
> so that that approach still works without making a mess.

No big deal to me to add that both the .gitignore entry and the
cleanup rule if that's annoying for some. FWIW, I just have some
scripts lying around to launch my upgrade commands in isolated paths,
pretty much like the TAP tests.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-06-15 02:26:18 pgsql: Tweak behavior of psql --single-transaction depending on ON_ERRO
Previous Message Tom Lane 2022-06-15 00:11:59 Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test