Re: Assert name/short_desc to prevent SHOW ALL segfault

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Steve Chavez <steve(at)supabase(dot)io>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Assert name/short_desc to prevent SHOW ALL segfault
Date: 2022-05-25 05:31:01
Message-ID: Yo2/FfbtzTrwKgsM@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 25, 2022 at 12:05:55AM -0500, Steve Chavez wrote:
> Thank you for the reviews Nathan, Michael.
>
> I agree with handling NULL in ShowAllGUCConfig() instead.
>
> I've attached the updated patch.

Shouldn't the same check as extra_desc be done in
GetConfigOptionByNum() for short_desc (point of upthread)? See
3ac7d024, though -fsanitize=undefined does not apply here, I guess.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-05-25 06:17:39 Re: Assert name/short_desc to prevent SHOW ALL segfault
Previous Message Steve Chavez 2022-05-25 05:05:55 Re: Assert name/short_desc to prevent SHOW ALL segfault