| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Remove support for Visual Studio 2013 |
| Date: | 2022-05-26 20:57:39 |
| Message-ID: | Yo/pw2D8MQutXmtR@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 26, 2022 at 10:43:11AM -0500, Justin Pryzby wrote:
Ah, thanks. I forgot to grep for those patterns. Good catches.
> Maybe consider removing this workaround? The original problem report indicated
> that it didn't affect later versions:
>
> src/backend/optimizer/path/costsize.c: /* This apparently-useless variable dodges a compiler bug in VS2013: */
Hence reverting 3154e16. Sure!
> I'm not sure if it's worth removing this one, though:
>
> src/port/strtof.c: * On Windows, there's a slightly different problem: VS2013 has a strtof()
Yeah.. I am not completely sure if all the patterns mentioned for
VS2013 apply to Cygwin/Mingw, so keeping it around could be more
beneficial.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2022-05-26 20:59:01 | Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~ |
| Previous Message | Justin Pryzby | 2022-05-26 20:52:18 | Re: pg_upgrade test writes to source directory |