Re: Fix primary crash continually with invalid checkpoint after promote

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, 875941708(at)qq(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, masao(dot)fujii(at)oss(dot)nttdata(dot)com, nathandbossart(at)gmail(dot)com
Subject: Re: Fix primary crash continually with invalid checkpoint after promote
Date: 2022-04-27 03:00:49
Message-ID: Ymix4QTcqXKaiaDY@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Wed, Apr 27, 2022 at 11:24:11AM +0900, Kyotaro Horiguchi wrote:
> Zhao Rui's proposal is retension of WAL files according to (the wrong
> content of) control file.
>
> Aside from the fact that it may let slots be invalidated ealier, It's
> not great that an acutally performed restartpoint is forgotten, which
> may cause the next crash recovery starts from an already performed
> checkpoint.

Yeah, I was analyzing this problem and took a look at what's proposed
here, and I agree that what is proposed on this thread would just do
some unnecessary work if we find ourselves in a situation where we
we need to replay from a point earlier than necessary, aka the
checkpoint that should have been already finished.
--
Michael

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2022-04-27 08:13:12 Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work.
Previous Message Kyotaro Horiguchi 2022-04-27 02:24:11 Re: Fix primary crash continually with invalid checkpoint after promote

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-04-27 03:15:40 Re: pgsql: Add contrib/pg_walinspect.
Previous Message Kyotaro Horiguchi 2022-04-27 02:24:11 Re: Fix primary crash continually with invalid checkpoint after promote