| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set |
| Date: | 2022-04-01 03:54:32 |
| Message-ID: | YkZ3eE3yzfFv4zsV@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 01, 2022 at 10:16:48AM +0900, Michael Paquier wrote:
> Okay, done after an extra round of self-review. I have finished by
> tweaking a couple of comments, and adjusted further TESTING to explain
> what needs to be done to have a dump compatible with the test. Let's
> now see what goes wrong.
So, the first reports are published, and the buildfarm is rather cool
on the matter. wrasse is the only buildfarm member that has reported
a failure, complaining that the dumps generated do not match. I am
not completely sure what's going on there, so I have applied an extra
patch to get more information from the logs on failures, and switched
the test to use File::Compare::compare() to check if the dumps match.
This last part feels safer in the long run, anyway. There should be a
diff command as previous runs used test.sh, so perhaps this is an
issue with its perl. The next report should tell more.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-04-01 04:00:20 | Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set |
| Previous Message | Justin Pryzby | 2022-04-01 03:51:59 | Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set |