Re: pg_dump new feature: exporting functions only. Bad or good idea ?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Laetitia Avrot <laetitia(dot)avrot(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Ryan Lambert <ryan(at)rustprooflabs(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, ahsan hadi <ahsan(dot)hadi(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_dump new feature: exporting functions only. Bad or good idea ?
Date: 2022-04-07 05:43:39
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sat, Mar 26, 2022 at 09:53:19AM +0100, Laetitia Avrot wrote:
> I think it's time to sum up what we want to do:
> - We'd like to use switches to export objects according to a pattern.
> - For each object type we will have an --object=PATTERN flag and a
> --exclude-object=PATTERN
> - Having a short flag for each of the long flags is not mandatory
> - The object types that pg_dump can select so far are:
> - table (already written)
> - schema (already written)

> - extension (half-written, --exclude-extension not written)

I would be to blame on this item.

> - routine (TBD ASAP). Routine flag operates on stored functions, stored
> procedures, aggregate functions, and window functions.
> - By default, pg_dump does not export system objects but we found out that
> we could use --table='pg_catalog.*' to export them. This is a bug and will
> be fixed. pg_dump won't have the ability to export any system object
> anymore. Should the fix belong to that patch or do I need to create a
> separate patch? (Seems to me it should be separated)
> If everyone is ok with the points above, I'll write both patches.

Looks clear to me that a different design is wanted here, and that
this won't make it for v15, so I have marked the patch as returned
with feedback in the CF app.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-04-07 05:53:22 Re: Supply restore_command to pg_rewind via CLI argument
Previous Message Michael Paquier 2022-04-07 05:40:55 Re: Change the csv log to 'key:value' to facilitate the user to understanding and processing of logs