Re: pgsql: Add option to use ICU as global locale provider

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add option to use ICU as global locale provider
Date: 2022-03-18 02:01:11
Message-ID: YjPn5+Y9Gj58PlEW@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi Peter,

On Thu, Mar 17, 2022 at 10:22:32AM +0000, Peter Eisentraut wrote:
> Add option to use ICU as global locale provider
>
> This adds the option to use ICU as the default locale provider for
> either the whole cluster or a database. New options for initdb,
> createdb, and CREATE DATABASE are used to select this.
>
> Since some (legacy) code still uses the libc locale facilities
> directly, we still need to set the libc global locale settings even if
> ICU is otherwise selected. So pg_database now has three
> locale-related fields: the existing datcollate and datctype, which are
> always set, and a new daticulocale, which is only set if ICU is
> selected. A similar change is made in pg_collation for consistency,
> but in that case, only the libc-related fields or the ICU-related
> field is set, never both.

FYI, prion is complaining here:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2022-03-18%2001%3A43%3A13

Some details:
# Failed test 'fails for invalid ICU locale: matches'
# at t/001_initdb.pl line 107.
# '2022-03-18 01:54:58.563 UTC [504] FATAL: could
# not open collator for locale "@colNumeric=lower":
# U_ILLEGAL_ARGUMENT_ERROR
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Julien Rouhaud 2022-03-18 03:12:44 Re: pgsql: Add option to use ICU as global locale provider
Previous Message Michael Paquier 2022-03-18 01:49:22 pgsql: doc: Remove mention to in-place tablespaces for pg_tablespace_lo

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-03-18 02:06:00 Re: Assert in pageinspect with NULL pages
Previous Message Michael Paquier 2022-03-18 01:38:54 Re: Teach pg_receivewal to use lz4 compression