| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*) |
| Date: | 2022-03-26 11:23:54 |
| Message-ID: | Yj73yraY43IhgwiK@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 23, 2022 at 03:17:35PM +0900, Michael Paquier wrote:
> FWIW, per my review the bit of the patch set that I found the most
> relevant is the addition of a note in the docs of pg_stat_file() about
> the case where "filename" is a link, because the code internally uses
> stat(). The function name makes that obvious, but that's not
> commonly known, I guess. Please see the attached, that I would be
> fine to apply.
Hmm. I am having second thoughts on this one, as on Windows we rely
on GetFileInformationByHandle() for the emulation of stat() in
win32stat.c, and it looks like this returns some information about the
junction point and not the directory or file this is pointing to, it
seems. At the end, it looks better to keep things simple here, so
let's drop it.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Erik Rijkers | 2022-03-26 11:29:30 | Re: SQL/JSON: JSON_TABLE |
| Previous Message | Thomas Munro | 2022-03-26 11:07:57 | Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work. |