Re: Add pg_freespacemap extension sql test

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dong Wook Lee <sh95119(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add pg_freespacemap extension sql test
Date: 2022-03-11 05:51:35
Message-ID: YirjZxEFY9eq/opN@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 09, 2022 at 08:13:15PM +0900, Dong Wook Lee wrote:
> I agree with you, but I have no good idea how to deal with it.

Well, my guess is that you basically just care about being able to
detect if there is free space in the map or not, which goes down to
detecting if pg_freespace() returns 0 or a number strictly higher than
0, so wouldn't it be enough to stick some > 0 in your test queries?
Btw, if you want to test 32-bit builds, gcc allows that by passing
down -m32.

> Can the Perl TAP test be a good way?

That does not seem necessary here.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-03-11 06:03:18 Re: WIP: WAL prefetch (another approach)
Previous Message Thomas Munro 2022-03-11 05:35:26 Re: WIP: WAL prefetch (another approach)