Re: pg_tablespace_location() failure with allow_in_place_tablespaces

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: pg_tablespace_location() failure with allow_in_place_tablespaces
Date: 2022-03-07 11:36:20
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Mar 04, 2022 at 03:44:22PM +0900, Michael Paquier wrote:
> The use may be limited to any automated testing and
> allow_in_place_tablespaces is a developer GUC, still it seems to me
> that there is an argument to allow the case rather than tweak any
> tests to hardcode a path with the tablespace OID. And any other code
> paths are able to handle such tablespaces, be they in recovery or in
> tablespace create/drop.
> A junction point is a directory on WIN32 as far as I recall, but
> pgreadlink() is here to ensure that we get the correct path on
> a source found as pgwin32_is_junction(), so we can rely on that. This
> stuff has led me to the attached.

Thomas, I'd rather fix this for the sake of the tests. One point is
that the function returns a relative path for in-place tablespaces,
but it would be easy enough to append a DataDir. What do you think?

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2022-03-07 11:56:52 Re: Add parameter jit_warn_above_fraction
Previous Message Ashutosh Bapat 2022-03-07 11:30:56 Re: Handle infinite recursion in logical replication setup