Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set
Date: 2022-03-03 05:03:38
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Mar 02, 2022 at 12:07:29AM -0800, Andres Freund wrote:
>> +++ b/src/bin/pg_upgrade/t/
>> @@ -0,0 +1,9 @@
>> +use strict;
>> +use warnings;
>> +
>> +use PostgreSQL::Test::Utils;
>> +use Test::More tests => 8;
> Outdated.


>> +program_help_ok('pg_upgrade');
>> +program_version_ok('pg_upgrade');
>> +program_options_handling_ok('pg_upgrade');
> Unrelated. But I kinda wish we'd do this in a saner manner than copying this
> test into every binary. E.g. by ensuring that all tools installed in the temp
> install are tested or such.

Perhaps. I am sticking with the existing style for now.

>> +# The test of pg_upgrade consists in setting up an instance. This is the
>> +# source instance used for the upgrade. Then a new and fresh instance is
>> +# created, and is used as the target instance for the upgrade.
> This seems a bit repetitive. Lots of "instance".

Indeed. I have reworked the whole, rather than just those three

>> +if ( (defined($ENV{olddump}) && !defined($ENV{oldinstall}))
>> + || (!defined($ENV{olddump}) && defined($ENV{oldinstall})))
> Odd indentation. Spaces between parens?

Well, perltidy tells me that this is right.

>> +$newnode->init(extra => [ '--wal-segsize', '1', '--allow-group-access' ]);
> I'd copy the comments from wrt --wal-segsize,
> --allow-group-access.


Attachment Content-Type Size
v11-0001-Switch-tests-of-pg_upgrade-to-use-TAP.patch text/x-diff 27.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Imseih (AWS), Sami 2022-03-03 05:08:43 Re: Add index scan progress to pg_stat_progress_vacuum
Previous Message Japin Li 2022-03-03 04:10:38 Re: Doc about how to set max_wal_senders when setting minimal wal_level