Re: pgsql: Add TAP test to automate the equivalent of check_guc

From: Christoph Berg <myon(at)debian(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc
Date: 2022-02-12 16:31:55
Message-ID: Ygfg+7yePes1X/A9@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Re: Tom Lane
> Christoph Berg <myon(at)debian(dot)org> writes:
> > I think the "bug" here is that vanilla PG doesn't support installing
> > in FHS locations with /usr/lib and /usr/share split, hence the Debian
> > patch.
>
> I'm confused by this statement. An out-of-the-box installation
> produces trees under $PREFIX/lib and $PREFIX/share. What about
> that is not FHS compliant? And couldn't you fix it using the
> installation fine-tuning switches that configure already provides?

To support multiple major versions in parallel, we need
/usr/lib/postgresql/NN/lib and /usr/share/postgresql/NN, so it's not a
single $PREFIX. But you are correct, and ./configure supports that.

I was confusing that with this: The problem that led to the pg_config
patch years ago was that we have a /usr/bin/pg_config in
(non-major-version-dependant) libpq-dev, and
/usr/lib/postgresql/NN/bin/pg_config in the individual
postgresql-server-dev-NN packages, and iirc the /usr/bin version
didn't particularly like the other binaries being in
/usr/lib/postgresql/NN/bin/.

I guess it's time to revisit that problem now and see if it can be
solved more pretty today on our side.

Sorry for the rumbling,
Christoph

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-02-12 16:50:00 Re: pgsql: Add TAP test to automate the equivalent of check_guc
Previous Message Tom Lane 2022-02-12 16:23:23 Re: pgsql: Add TAP test to automate the equivalent of check_guc

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-02-12 16:47:20 Re: Why is src/test/modules/committs/t/002_standby.pl flaky?
Previous Message Tom Lane 2022-02-12 16:23:23 Re: pgsql: Add TAP test to automate the equivalent of check_guc