| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Replacing TAP test planning with done_testing() |
| Date: | 2022-02-10 00:58:27 |
| Message-ID: | YgRjM7fJkbIb5iTc@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 09, 2022 at 02:49:47PM -0500, Tom Lane wrote:
> =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari(at)ilmari(dot)org> writes:
>> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>>> The attached patch removes all Test::More planning and instead ensures that all
>>> tests conclude with a done_testing() call. While there, I also removed a few
>>> exit(0) calls from individual tests making them more consistent.
>
>> LGTM, +1.
>
> LGTM too.
Not tested, but +1. Could it be possible to backpatch that even if
this could be qualified as only cosmetic? Each time a test is
backpatched we need to tweak the number of tests planned, and that may
change slightly depending on the branch dealt with.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-02-10 01:01:08 | Re: Justin Pryzby <pryzby@telsasoft.com> |
| Previous Message | Peter Smith | 2022-02-10 00:41:56 | Re: row filtering for logical replication |