Re: pg_upgrade should truncate/remove its logs before running

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Date: 2022-02-07 00:33:13
Message-ID: YgBoyUzQxwpXwNWY@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Feb 06, 2022 at 08:32:59AM -0500, Andrew Dunstan wrote:
> *sigh* Sometimes I have a mind like a sieve. I prepped the release a few
> days ago and meant to come back the next morning and send out emails
> announcing it, as well as rolling it out to my animals, and got diverted
> so that didn't happen and it slipped my mind. I'll go and do those
> things now.

Thanks. I saw the release listed after a couple of days of
hibernation, and that one week went by since, so I thought that the
timing was pretty good. I did not check the buildfarm members though,
sorry about that.

> But the commit really shouldn't have happened until we know that most
> buildfarm owners have installed it. It should have waited wait not just
> for the release but for widespread deployment. Otherwise we will just
> lose any logging for an error that might appear.

Would it be better if I just revert the change for now then and do it
again in one/two weeks? The buildfarm is green, so keeping things as
they are does not sound like a huge deal to me, either, for this
case.

FWIW, I have already switched my own animal to use the newest
buildfarm client.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-02-07 00:39:39 Re: pg_upgrade should truncate/remove its logs before running
Previous Message Chapman Flack 2022-02-06 22:33:38 Re: GSoC 2022