| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "andrew(at)dunslane(dot)net" <andrew(at)dunslane(dot)net>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: drop tablespace failed when location contains .. on win32 |
| Date: | 2022-01-31 08:15:33 |
| Message-ID: | YfeapcO2WECIhMQo@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 30, 2022 at 04:50:03PM -0500, Tom Lane wrote:
> Here's a revised patch version that does it like that. I also
> reviewed and simplified the canonicalize_path logic. I think
> this is committable.
Thanks for the updated version. The range of the tests looks fine
enough, and the CF bot does not complain. The code is
straight-forward and pretty clear in terms of the handling of ".",
".." and the N-depth handling necessary.
Should we have tests for WIN32 (aka for driver letters and "//")?
This could be split into its own separate test file to limit the
damage with the alternate outputs, and the original complain was from
there.
> (I suspect that adminpack's checks for unsafe file names could
> now be simplified substantially, because many of the corner cases
> it worries about are no longer possible, as evidenced by the change
> in error message there. I've not pursued that, however.)
Fine by me to let this part for later.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-01-31 08:29:49 | Re: [PATCH] Accept IP addresses in server certificate SANs |
| Previous Message | Michael Paquier | 2022-01-31 07:57:13 | Re: Catalog version access |