Re: refactoring basebackup.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: refactoring basebackup.c
Date: 2022-01-26 01:23:46
Message-ID: YfCiolb4hv+Z9V8J@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 25, 2022 at 03:54:52AM +0000, Shinoda, Noriyoshi (PN Japan FSIP) wrote:
> Michael, I am proposing to that we remove this message as part of
> this commit:
>
> - pg_log_info("no value specified for compression
> level, switching to default");
>
> I think most people won't want to specify a compression level, so
> emitting a message when they don't seems too verbose.

(Just noticed this message as I am not in CC.)
Removing this message is fine by me, thanks!
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-01-26 01:29:29 Re: refactoring basebackup.c
Previous Message Michael Paquier 2022-01-26 01:15:27 Re: Refactoring of compression options in pg_basebackup