| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_upgrade should truncate/remove its logs before running |
| Date: | 2022-01-20 04:38:45 |
| Message-ID: | YejnVflKrW+IQZtx@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 19, 2022 at 09:59:14PM -0600, Justin Pryzby wrote:
> We require that the dir not exist, by testing if (mkdir()).
> So it's okay if someone specifies ../whatever or $CWD.
What I am scared of here is the use of rmtree() if we allow something
like that. So we should either keep the removal code in its original
shape and allow such cases, or restrict the output path. At the end,
something has to change. My points are in favor of the latter because
I don't really see anybody doing the former. You favor the former.
Now, we are not talking about a lot of code for any of these, anyway.
Perhaps we'd better wait for more opinions.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey V. Lepikhov | 2022-01-20 05:05:57 | Re: POC: GROUP BY optimization |
| Previous Message | Kyotaro Horiguchi | 2022-01-20 04:25:41 | Re: standby recovery fails (tablespace related) (tentative patch and discussion) |