| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Bogus duplicate command issued in pg_dump |
| Date: | 2022-01-24 02:25:33 |
| Message-ID: | Ye4OHemJh8S5q1UX@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 23, 2022 at 01:31:03PM -0500, Tom Lane wrote:
> We could consider a more global change to get rid of using
> appendPQExpBuffer where it's not absolutely necessary, so that
> there are fewer bad examples to copy. Another idea is to deem
> it an anti-pattern to end a query with a semicolon. But I don't
> have a lot of faith in people following those coding rules in
> future, either. It'd also be a lot of code churn for what is
> in the end a relatively harmless bug.
Could a backend-side, run-time configurable developper GUC,
potentially help here? This could look after multiple queries in code
paths where we don't want any, once you combine it with a specific
compilation flag à-la-ENFORCE_REGRESSION_TEST.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-01-24 02:31:52 | Re: Replace uses of deprecated Python module distutils.sysconfig |
| Previous Message | Tom Lane | 2022-01-24 02:25:04 | Re: XLogReadRecord() error in XlogReadTwoPhaseData() |